553 feature refactor segmentationdataset class #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesAuthier
previously approved these changes
Feb 8, 2024
inference_segmentation.py
Outdated
| @@ -158,19 +158,21 @@ def segmentation(param, | |||
|
|
|||
| """ | |||
| sample = {"image": None, "mask": None, 'metadata': None} | |||
| start_seg = time.time() | |||
| # start_seg = time.time() | |||
There was a problem hiding this comment.
Do we need to keep this? (same for the end time)
There was a problem hiding this comment.
I will clean it out
remtav
reviewed
Feb 8, 2024
| SegmentationDataset) | ||
|
|
||
|
|
||
| class TestSegmentationDataset: |
|
nicely done. What was the initial motivation for this refactoring @valhassan ? Adding a test :) ? |
mpelchat04
previously approved these changes
Feb 13, 2024
dataset/create_dataset.py
Outdated
There was a problem hiding this comment.
this is clean, thanks!
added 2 commits
February 16, 2024 15:12
…into 553-feature-refactor-segmentationdataset-class
valhassan
dismissed stale reviews from mpelchat04 and CharlesAuthier
via
1403896
LucaRom
approved these changes
Feb 22, 2024
mpelchat04
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting your PR and helping us with GDL.
Please read the template below, fill it out as appropriate, and make additional changes to your code as needed.
Please feel free to submit your PR even if it doesn't satisfy all of the requirements below.
If you need assistance or review from a maintainer, add the label Status: Help Needed or Status: Review Needed respectively.
After review, a maintainer will add the label Status: Revision Needed if further work is required for the PR to be merged.
Description
Fixes #553
Type of change
What types of changes does your code introduce? Put an
xin all the boxes that apply:How Has This Been Tested?
added unit test for SegmentionDataset class
Screenshots (if applicable):
Checklist:
If you're unsure about any of these, don't hesitate to ask. We're here to help!
If your PR does not fulfill all of the requirements in the checklist above, that's OK! If you need help, @-mention a maintainer and/or add the Status: Help Needed label.