Hot fix docker image build #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda config --set channel_priority strict
conda config --set channel_priority strict
|
can you combine all the commit to make it clean pls :) |
ms888ekb
requested review from
CharlesAuthier,
remtav,
valhassan and
mpelchat04
valhassan
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Removing the container function seems like a temporary fix. Ideally, we would like to run our tests in the same environment (docker container) as we would in production. This implementation removes any validation of the docker image. Also, I think all docker image builds should be done inside of GitHub actions (Deprecating build-on-tag). We need more discussions on this!
remtav
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pointed system variable from the OS's to Conda's installations lib folder.