Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] PR: Upgrade Python packages #1389

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

[1pt] PR: Upgrade Python packages #1389

wants to merge 2 commits into from

Conversation

mluck
Copy link
Contributor

@mluck mluck commented Dec 30, 2024

Updates Python packages to resolve dependency conflicts that were preventing Dockerfile.dev to build on Mac. This also resolves two security warnings: https://github.com/NOAA-OWP/inundation-mapping/security/dependabot/51 and https://github.com/NOAA-OWP/inundation-mapping/security/dependabot/52.

Resolves #1380.

Changes

  • Pipfile and Pipfile.lock: Upgrades Python packages

Testing

Successfully built Dockerfile.dev on Mac and ran get_sample_data.py and fim_pipeline.sh in new container. Also tested on Ubuntu EC2.

Deployment Plan (For developer use)

How does the changes affect the product?

  • Code only?
  • If applicable, has a deployment plan be created with the deployment person/team?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@mluck mluck added bug Something isn't working dependencies Pull requests that update a dependency file labels Dec 30, 2024
@mluck mluck requested a review from RobHanna-NOAA December 30, 2024 17:09
@mluck mluck self-assigned this Dec 30, 2024
@mluck
Copy link
Contributor Author

mluck commented Dec 30, 2024

Because the Docker image wouldn't build on Mac, I first used the ghcr.io/osgeo/gdal:ubuntu-small-3.8.4 base image to install pipenv (code below) to modify the Python packages and update the Pipfile and Pipfile.lock files.

apt update
apt install pip
pip3 install pipenv==2024.0.1 && PIP_NO_CACHE_DIR=off pipenv install

@RobHanna-NOAA
Copy link
Contributor

Tested for a docker build, fim-pipeline, and alpha test on our EC2. Looks good. Next up is test on a personal non-noaa windows machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[13pt] Docker build fails on Mac
2 participants