Rework 07 and 11 #157
Merged
Rework 07 and 11 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes "Roadmap to FIMS File Structure and Organization" info will be put in README files in each folder eventually, see NOAA-FIMS/FIMS#650 * Removes section on "Merge Conflicts" given the 3-1 vote for removing it in #144 * Removes section on "GitHub Actions Results" because it is a button that is visible from the top of the repository and this information is not specific to FIMS * Removes "GitHub Teams" because we are not using them * Moves "Commit Messages" to style guides * Remove hard-coded wrap on lines
Thanks to @bai-lee-noaa for letting me know when things were not working for me.
rather than using the glossary Closes #144
cmlegault
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Thanks Kelli, I approve these changes. I like the new links for learning C++ you've added. I'm fine with the sections you've removed, many were either not providing much information or were too far in the weeds to be truly useful. You've done a nice job balancing the need for information with the desire to keep the amount of information manageable.
|
Thanks Chris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature?
Attempted to make the collaborative workflow easier to maintain and understand by only holding the most relevant information.
How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?
NO
@cmlegault I chose you as a reviewer because you contributed to #144 and did not want sections removed so I am trying to make sure that I did not remove too much from the guide. Thanks.