Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove issue templates that are now in .github repo #149

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

kellijohnson-NOAA
Copy link
Collaborator

What is the feature?

  • Moves PR and issue templates to NOAA-FIMS/.github/.github so they are available to all repositories within NOAA-FIMS.

How have you implemented the solution?

Moved the files to NOAA-FIMS/.github/.github see NOAA-FIMS/.github@33c261d for the exact commit.

Does the PR impact any other area of the project?

One template, handbook_addition.md was left as is.

How to test this change

Go to another repository in FIMS and see the available issue templates 🤯 or see below
image

Developer pre-PR checklist

  • I relied on GitHub actions to 🧪 things for me while I sat on the 🛋️.

@kellijohnson-NOAA kellijohnson-NOAA added theme: branches Branch structure, rules, etc. P3 Low priority task labels Jul 2, 2024
@kellijohnson-NOAA kellijohnson-NOAA added this to the M2 milestone Jul 2, 2024
Copy link
Contributor

@Bai-Li-NOAA Bai-Li-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the templates.

There is a syntax error in the feature_request.yml inthe .github repo, which does not appear in your snapshot or available issue templates in other repos. I will report this issue on the .github repo.

@kellijohnson-NOAA
Copy link
Collaborator Author

Thanks @Bai-Li-NOAA!

@kellijohnson-NOAA
Copy link
Collaborator Author

@Bai-Li-NOAA I just found out that the issue templates in .github will not work in this repository unless we delete the entire folder, i.e., delete NOAA-FIMS/collaborative_workflow/.github/ISSUE_TEMPLATE, and thus, we need to decide if the [handbook-addition.md](https://github.com/NOAA-FIMS/collaborative_workflow/blob/main/.github/ISSUE_TEMPLATE/handbook-addition.md) is worth migrating over to the .github repository, which would make it show up in every repository or if we should delete this pull request?

@iantaylor-NOAA
Copy link
Contributor

I vote to delete https://github.com/NOAA-FIMS/collaborative_workflow/blob/main/.github/ISSUE_TEMPLATE/handbook-addition.md as it doesn't add much and we can easily create handbook addition issues from a blank issue easily enough now that we've been developing the handbook for a while.

Templates are now in .github repo
@kellijohnson-NOAA kellijohnson-NOAA merged commit ca9abb5 into main Jul 8, 2024
1 check passed
@kellijohnson-NOAA kellijohnson-NOAA deleted the delete-templates branch July 8, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low priority task theme: branches Branch structure, rules, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants