-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update user install instructions, Add instructions for codespaces #146
Conversation
If we want to finish #98 we could add the R-universe badge to the NOAA-FIMS/FIMS/README page. Here is the markdown that is needed to include the badge
|
Thanks @kellijohnson-NOAA , I added NOAA-FIMS/FIMS#636 and made some additional changes here to address #98 fully. The developer installation instructions were moved into the collaborative workflow doc and linked on the FIMS readme. The R universe badge was added on the FIMS readme. |
06-developer-software-guide.Rmd
Outdated
need to contribute to this project as well as ways FIMS can be installed. This is in addition to the software | ||
dependencies described in the [user installation | ||
guide](#user-installation-guide) which you should ensure are installed | ||
first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this second sentence "This is in addition to the software ..."
Thanks @k-doering-NOAA for all of the changes. I have a few more comments but I am approving it now. |
@kellijohnson-NOAA I tried to address your suggestions! If there is anything else, feel free to modify directly and merge in when you feel it is finished :) |
Clearly define user versus developer install instructions and move developer instructions from NOAA-FIMS/FIMS/README to the collaborative workflow in the developers section. In exchange for adding how to install from R-universe on the same readme as these instructions do not require compiling. Many breadcrumbs were left in the workflow explaining where users and developers can find relevant information for install and codespaces. All work was done by @k-doering-NOAA with suggestions from @kellijohnson-NOAA and @iantaylor-NOAA. Close #122 Close #98 Close #93 Close #117
53b22fd
to
f4a7a9e
Compare
I squashed the commits into one commit and update the commit message to reflect the work done. Once checks pass, I will merge into main. |
For users and developers, where the information for the latter was moved to the collaborative workflow see NOAA-FIMS/collaborative_workflow#146. A badge for R-universe was placed in the list of all badges! Work was done by @k-doering-NOAA with suggestions by @kellijohnson-NOAA Part of NOAA-FIMS/collaborative_workflow#98
For users and developers, where the information for the latter was moved to the collaborative workflow see NOAA-FIMS/collaborative_workflow#146. A badge for R-universe was placed in the list of all badges! Work was done by @k-doering-NOAA with suggestions by @kellijohnson-NOAA Part of NOAA-FIMS/collaborative_workflow#98
This pull request:
I believe this addresses #122 and #93 ; and partially addresses #98.