refactor(proportion_female): Remove comments #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proportion_female was commented out in all of the case studies because setting it was not doing anything to the model. In M2 we will remove the ability to set this parameter vector because it was not doing anything. In the future we will add the feature back. This change does nothing to the results. Simplified a comment in the scamp case study to say that it is fixed at 0.5 instead of you have the ability to estimate it. Part of NOAA-FIMS/FIMS#638 and NOAA-FIMS/seaside-chats#7
kellijohnson-NOAA
added
kind: refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?