Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create SEFSC scamp example #38

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Create SEFSC scamp example #38

merged 4 commits into from
Jul 3, 2024

Conversation

KyleShertzer-NOAA
Copy link
Contributor

Trying scamp example. Want to use github actions to test if it runs.

@KyleShertzer-NOAA
Create SEFSC scamp example
8b54c71 
Only updated qmd file
@iantaylor-NOAA
Copy link
Contributor

Looks like the action is failing due to library(tidyverse) on line 74 of the scamp qmd file. Either tidyverse needs to be added to setup.qmd or the scamp file could be modified to only call on packages that are already in setup, listed at https://github.com/NOAA-FIMS/case-studies/blob/main/content/setup.qmd#L6.

@KyleShertzer-NOAA
Add scamp rdat file.
841a782 
Used dplyr package instead of tidyverse package
@iantaylor-NOAA
Copy link
Contributor

@KyleShertzer-NOAA, you may have figured this out already, but I think changing from windows() and savePlots() to png() and dev.off() as in https://github.com/NOAA-FIMS/case-studies/blob/main/content/AFSC-GOA-pollock.qmd#L141-L173 will work on Linux which the GitHub Action is using.

@KyleShertzer-NOAA
Updated SEFSC-scamp.qmd
d4310dc 
For compatibility with UNIX, changed plotting calls from windows() and savePlots() to png() and dev.off()
@iantaylor-NOAA
Copy link
Contributor

Nice job @KyleShertzer-NOAA! The artifact at the bottom of the successful github action https://github.com/NOAA-FIMS/case-studies/actions/runs/9781929404 contains the HTML page (compressed as a .tar file within a .zip file). The page looks good:
image

@KyleShertzer-NOAA KyleShertzer-NOAA merged commit 0202b27 into main Jul 3, 2024
1 check passed
@KyleShertzer-NOAA KyleShertzer-NOAA deleted the SEFSC-scamp branch July 3, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellijohnson-NOAA kellijohnson-NOAA Awaiting requested review from kellijohnson-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleShertzer-NOAA @iantaylor-NOAA