commented out inconsistent tests #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #../wgrib2/wgrib2 wind.grb -wind_uv uv.grb | ||
| #../wgrib2/wgrib2 uv.grb > uv.txt | ||
| #cat uv.txt | ||
| #diff -w uv.txt data/ref_uv.gdas.t12z.pgrb2.1p00.anl.75r.grib2.inv |
There was a problem hiding this comment.
Probably you just need to comment out the diff calls.
But first, try using cmp instead of diff to compare the files. I think that might work better.
There was a problem hiding this comment.
I switched to diff so I can ignore white space in the file comparisons.
For these tests the outputs are truly different, but only sometimes. I can never seem to recreate the issue locally, it only occurs on the CI every few runs or so.
edwardhartnett
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #175
I'm just commenting these out for now so they don't mess wit other PRs