Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find netCDF through cmake and remove netCDF tarball from repo #105

Closed
wants to merge 3 commits into from
Closed

Find netCDF through cmake and remove netCDF tarball from repo #105

wants to merge 3 commits into from

Conversation

edwardhartnett
Copy link
Contributor

Fixes #69

@edwardhartnett edwardhartnett requested a review from webisu March 29, 2024 13:17
@edwardhartnett
Copy link
Contributor Author

edwardhartnett commented Mar 29, 2024 •
edited
Loading

This is failing to build like this:

In file included from /home/runner/work/wgrib2/wgrib2/wgrib2/wgrib2/wgrib2.h:13,
                 from /home/runner/work/wgrib2/wgrib2/wgrib2/wgrib2/Config.c:6:
/home/runner/work/wgrib2/wgrib2/wgrib2/wgrib2/config.h:5: warning: "USE_NETCDF4" redefined
    5 | #define USE_NETCDF4
      | 
<command-line>: note: this is the location of the previous definition

@webisu I forgot to ask you about this at the meeting...

@edwardhartnett edwardhartnett deleted the ejh_netcdf branch July 17, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webisu webisu Awaiting requested review from webisu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove netCDF tarball from the repo and the makefile build
1 participant
@edwardhartnett