Fix erroneous use of sys.exit in renderer #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An empty PR in jcb-gdas with the same branch name confirms the testing to be working over there and that the changes in this repo are sufficient. No changes to jcb-gdas are needed. NOAA-EMC/jcb-gdas#34 |
CoryMartin-NOAA
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a use of sys.exit in the renderer. Since the testing calls this function using threading this is not safe since it causes the code to simply hang instead of throwing the actual exception.
A PR in jcb-gdas caused the testing to break but rather than seeing the issue, the testing would simply hang.
PR puts in the missing template in place and protects against the same issue happening in the future.