-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to jcb-gdas marine obs yamls #41
Conversation
… with prior modifications to the obs error and other filters that have been tested in the marine candidate experiment. Also, yamls for the new sea ice retrievals and SMAP/SMOS SSS retrievals have been added.
Thanks @JohnSteffen-NOAA , can you resolve the conflict (argo yaml)? Just ignore what ever I did to the argo yaml and use your filters. I was just making stuff work! |
Conflict resolved |
Looks fine to me, did you test some of these yamls @JohnSteffen-NOAA ? |
No, they have not been tested from the jcb-gdas side, only from the parm/soca/obs/config @guillaumevernieres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not merge this just yet, I don't think these yamls will work with the prep obs task. Were you able to test @JohnSteffen-NOAA ?
I'm building the ctests now @guillaumevernieres . I'll update when I get to the prep obs task. |
@JohnSteffen-NOAA Do you know where these are to be read in? Like from
since the obs space name is how the file itself, at least the ones under |
@JohnSteffen-NOAA , I tested some of the obs yamls, no complaints so I'm going to merge this. However, there are a few places in our scripts that still rely in the old obs yamls ... We'll need to fix this at some point. |
it's coming from a processed version of obs_list @AndrewEichmann-NOAA . We have to revisit that part of the code ... |
The ci error seems unrelated to your work @JohnSteffen-NOAA . |
@guillaumevernieres the testing issue is fixed now. |
This PR updates the marine observations yamls introduced in https://github.com/NOAA-EMC/jcb-gdas/commit/41ee2a276e2688d19eef7d3dcb9567e3042f6843 by modifying the observation errors and additional filters to be consistent with the marine candidate experiment.
It addresses this GDASApp issue https://github.com/NOAA-EMC/GDASApp/issues/1316.
Additionally, yamls for new sea ice retrievals and SMAP/SMOS retrievals are included.
Close NOAA-EMC/GDASApp#1316