-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off jb eval #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @guillaumevernieres. For backward compatibility I think it would be good to default to True
. And also allow users the option to keep using the feature. Then you can set the two settings to False
in your jcb settings.
By the way, when you create a jcb-algorithms PR, you also need to create an empty branch with the same name in the main jcb repo. This is unfortunately needed for the CI. It allows for the connection between jcb-algorithms and repos like jcb-gdas so that these changes can be tested against those repos. I'll try to remove that requirement soon. |
Co-authored-by: Dan Holdaway <[email protected]>
Roger that @danholdaway ... It looks like this is way more than a 5 mn gain.
We should turn that option off by default, this has been a huge waste of resources. |
I'm OK with setting the flags to e.g. |
I'm not 100% sure this fixes the memory issue on MSU HPC, but, while I was working on other things, I turned off the jb eval out of impatience to gain ~5+mn of runtime. I also noticed that the memory footprint is down to ~0.8TB for the 3DVARFGAT.
I'm testing with more iterations right now.