-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Aerosol DA to use JCB and Jedi class #3125
base: develop
Are you sure you want to change the base?
Switch Aerosol DA to use JCB and Jedi class #3125
Conversation
…e bias correction files from tarball (NOAA-EMC#2862)
…on files using jedi class (NOAA-EMC#2862)
…ns analysis scripts (NOAA-EMC#2862)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
92f60bd
marking this as ready to review as it will be ready once #3160 is resolved |
caa4500
Given approvals from @DavidNew-NOAA and @aerorahul , I will set up and run g-w CI for this PR on various machines once new fix files have been staged. @WalterKolczynski-NOAA and @KateFriedman-NOAA : g-w CI for this PR can not begin until the required fix files have been added to EIB staged fix file directories. See g-w issue #3160 for details. Note: We have no WCOSS2 dev access 12/16 through 12/20. If we are unable to run g-w CI for this PR before 12/16, we will need to wait until 12/21 or later for WCOSS2 testing. |
Description
This PR switches to using JCB for aerosol DA YAML generation + makes use of the Jedi class refactoring already done by @DavidNew-NOAA for the atmospheric JEDI-based DA.
Resolves #3035
Note this PR is in draft for 2 reasons. 1) Need associated GDASApp PR to be opened and merged first and 2) requires some fix file updates. This will be coordinated with an issue and linked to this PR once @andytangborn is satisfied with a first-attempt at the fix files.
Type of change
Change characteristics
How has this been tested?
Checklist