Encapsulate the marine 3dvar and hyb ctests under different cmake conditionals #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidNew-NOAA
approved these changes
Dec 6, 2024
RussTreadon-NOAA
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Didn't test but looks OK. Thanks for making a quick change @guillaumevernieres
|
Thanks for the quick review @RussTreadon-NOAA and @DavidNew-NOAA . I'll configure and check that the correct list of ctest is generated before I merge this. |
|
I played with the switches in the CMakeCache, it does what we want so merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's not fixing #1404 , but that should allow the nightly
cito not complain while @AndrewEichmann-NOAA or myself figure out a fix.