-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI driver #1401
base: develop
Are you sure you want to change the base?
Update CI driver #1401
Conversation
Automated GDASApp Testing Results:
|
Automated GDASApp Testing Results:
|
Automated GDASApp Testing Results:
|
Automated GDASApp Testing Results:
|
@DavidNew-NOAA , I am looking into the Orion failures from the role-da account. |
@RussTreadon-NOAA Thanks, yeah I'm a bit perplexed since Cory was able to run these tests successfully on Orion #1406 (comment) |
According to
Cory, you, and I can access
I added Let me ask Daryl if he can add |
Line 116 of
Variable |
Configure local copy of GDASApp
To this the following patches were added
With these changes all ctests pass
Received the following email
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve.
Orion and Hercules labels fail because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
@DavidNew-NOAA , do we expect any more changes to this PR or is it ready for final review, approval, and merger? |
@RussTreadon-NOAA I was kind of waiting on resolving the issue with MSU role accounts, but honestly that shouldn't hold up this PR. We can resolve any future problems with another quick bugfix PR. |
OK. We can wait. The request to add MSU |
Description
This PR consolidates the
run_ci.sh
andrun_gw_ci.sh
as well as thedriver.sh
andgw_driver.sh
scripts. Now, a-w
option indicates whether testing is taking place in the Global Workflow.A
-E ci_test1|ci_test2|...
is added todriver.sh
to exclude CI tests which don't need to be run. Those options are passed directly to thectest
command. The PR testing functionality indriver.sh
knows which tests to exclude based on the check boxes below. The output from the EMC bot for PR testing will now show the exact CTest command to indicate which tests were indeed excluded, just in case the check boxes are changed after the CI testing has begun.A PR template is now added for GDASApp that includes the CI testing checkboxes.
You can see below that I've tested the PR testing functionality.
Companion PRs
Issues
Automated CI tests to run in Global Workflow