Remove Modules/FindESMF.cmake - use ESMF's own version #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/remove_findesmf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
Modules/FindESMF.cmake- ESMF has its own, developer-blessed version that we should use and that provides a switch for the user to use the static or shared library.There will be changes needed for the applications and for the ESMF build (have the build system add
/path/to/esmf-install/cmaketoCMAKE_MODULES_PATH)For spack builds, I created an issue here: spack/spack#43575
I will keep this in draft mode until we've prepared the updates for the build systems and tested with at least ufs-weather-model and jedi-ufs.
This resolves #70