Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute F1 #233

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Compute F1 #233

merged 1 commit into from
Oct 16, 2023

Conversation

toonhasenack
Copy link
Collaborator

We added a case in the yadism/src/esf/exs.py file where one would like to calculate F1. Dependencies of this F1 have also been added.

@giacomomagni giacomomagni added the physics physics features label Oct 16, 2023
@Radonirinaunimi
Copy link
Member

Radonirinaunimi commented Oct 16, 2023

621d32f should not be part of this PR. Could you please remove it?

Edit: fixed now!

@giacomomagni giacomomagni linked an issue Oct 16, 2023 that may be closed by this pull request
Closed
@felixhekhorn felixhekhorn changed the title Compute f1 Compute F1 Oct 16, 2023
@toonhasenack toonhasenack merged commit 0a897b0 into master Oct 16, 2023
4 checks passed
@toonhasenack toonhasenack deleted the compute_F1 branch October 16, 2023 17:22
@felixhekhorn
Copy link
Contributor

@Radonirinaunimi actually, is this consistent? When you request the observable g1 from yadism you get $2xg_1$ as inherited from LeProHQ, right? - see also #222 ... shouldn't we do here the same? i.e. you request F1 but you get $2xF_1$? it is a bit confusing, I know, but if we do the same thing in polarized and unpolarized we release some of the tension, because all that matters is $g_1/F_1 = (2xg_1)/(2xF_1)$

@giacomomagni
Copy link
Collaborator

it is a bit confusing, I know, but if we do the same thing in polarized and unpolarized we release some of the tension, because all that matters is g1/F1=(2xg1)/(2xF1)

Good point, maybe the best would be the other way round ie remove the 2x pre-factor also from g1, no ?

@felixhekhorn
Copy link
Contributor

Good point, maybe the best would be the other way round ie remove the 2x pre-factor also from g1, no ?

this is of course an equally good option - the reason why I chose $2xg_1$ in my thesis is that with this normalization $F_2$ and $2xg_1$ have the analogous parton model expression, see e.g. PDG
grafik
(same holds for $xF_3$ ... )

@Radonirinaunimi
Copy link
Member

You are absolutely right @felixhekhorn! The initial idea was to account for the extra $2x$ in the $g_i$ later and keep using $F_1$. In hindsight, since the $F_1$ is mainly relevant in the $g_1/F_1$ context, we should provide here $2xF_1$ instead.

    elif kind == "2xF1":
        return np.array([1, -1, 0])

@Radonirinaunimi
Copy link
Member

I think this would be the easiest option (taking also into account your physics' argument), so if you agree @felixhekhorn, @giacomomagni we can correct this PR according to that.

@giacomomagni
Copy link
Collaborator

    elif kind == "2xF1":
        return np.array([1, -1, 0])

But let's keep calling it F1, otherwise it's even more inconsistent with the rest (right now both g1 and F3 are multiplied by x).
We should edit the documentation and spell this out properly there.

@Radonirinaunimi
Copy link
Member

    elif kind == "2xF1":
        return np.array([1, -1, 0])

But let's keep calling it F1, otherwise it's even more inconsistent with the rest (right now both g1 and F3 are multiplied by x). We should edit the documentation and spell this out properly there.

Ok, agreed. It's not ideal but yes we should make this explicit not only in the documentation but also in the various metadata when computing predictions.

@toonhasenack
Copy link
Collaborator Author

Okay, if everyone agrees I will generate a new pull request

@felixhekhorn
Copy link
Contributor

But let's keep calling it F1, otherwise it's even more inconsistent with the rest (right now both g1 and F3 are multiplied by x). We should edit the documentation and spell this out properly there.

I perfectly agree this should be proper documented

just to be explicit: what I believe are equal player are $F_2, F_L, xF_3, 2xF_1$ for unpolarized structure functions and $2xg_1, g_4, g_L, 2xg_5$ for the polarized case (see PDG above)

@Radonirinaunimi
Copy link
Member

But let's keep calling it F1, otherwise it's even more inconsistent with the rest (right now both g1 and F3 are multiplied by x). We should edit the documentation and spell this out properly there.

I perfectly agree this should be proper documented

just to be explicit: what I believe are equal player are F2,FL,xF3,2xF1 for unpolarized structure functions and 2xg1,g4,gL,2xg5 for the polarized case (see PDG above)

Perfect!

Okay, if everyone agrees I will generate a new pull request

So, @toonhasenack you could now proceed this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physics physics features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F1
4 participants