-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute F1 #233
Compute F1 #233
Conversation
621d32f should not be part of this PR. Could you please remove it? Edit: fixed now! |
d8e3acb
to
5422cf2
Compare
@Radonirinaunimi actually, is this consistent? When you request the observable |
Good point, maybe the best would be the other way round ie remove the |
You are absolutely right @felixhekhorn! The initial idea was to account for the extra elif kind == "2xF1":
return np.array([1, -1, 0]) |
I think this would be the easiest option (taking also into account your physics' argument), so if you agree @felixhekhorn, @giacomomagni we can correct this PR according to that. |
But let's keep calling it F1, otherwise it's even more inconsistent with the rest (right now both |
Ok, agreed. It's not ideal but yes we should make this explicit not only in the documentation but also in the various metadata when computing predictions. |
Okay, if everyone agrees I will generate a new pull request |
I perfectly agree this should be proper documented just to be explicit: what I believe are equal player are |
Perfect!
So, @toonhasenack you could now proceed this way. |
We added a case in the yadism/src/esf/exs.py file where one would like to calculate F1. Dependencies of this F1 have also been added.