Fix polarised TMC #222
Merged
Fix polarised TMC #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomomagni
approved these changes
Aug 22, 2023
felixhekhorn
approved these changes
Sep 11, 2023
|
I guess this could be merged now @felixhekhorn? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following fixes bugs present in the computation of polarised TMC. The bugs originate from the fact that our definition of
g1(as called by the line below):yadism/src/yadism/esf/tmc.py
Line 551 in 9e8d445
is actually$2xg_1$ and therefore the integrands were wrong. A Mathematica notebook is added that contains the correct integrals and computes their approximations.