Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eko #154

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Update eko #154

merged 3 commits into from
Sep 28, 2022

Conversation

felixhekhorn
Copy link
Contributor

  • I hope I caught everything
  • @giacomomagni do you have by chance still xspace_bench in your env and can quickly run a benchmark? Otherwise, let's not worry for the moment, I'd say
  • there is still the problem with setuptools (see also Problems in installing banana with poetry banana#27): poetry removes it, but then the package fails (the error was again No module named 'pkg_resources')

@felixhekhorn felixhekhorn added the dependencies Pull requests that update a dependency file label Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #154 (f9a9fac) into develop (2b560c5) will decrease coverage by 1.50%.
The diff coverage is 50.00%.

❗ Current head f9a9fac differs from pull request most recent head b089909. Consider uploading reports for the commit b089909 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #154      +/-   ##
===========================================
- Coverage    70.33%   68.83%   -1.51%     
===========================================
  Files           90       82       -8     
  Lines         4258     4008     -250     
===========================================
- Hits          2995     2759     -236     
+ Misses        1263     1249      -14     
Flag Coverage Δ
unittests 68.83% <50.00%> (-1.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fficient_functions/splitting_functions/__init__.py 37.50% <0.00%> (ø)
src/yadism/output.py 68.44% <50.00%> (-14.81%) ⬇️
src/yadism/esf/scale_variations.py 30.23% <66.66%> (+0.82%) ⬆️
src/yadism/coefficient_functions/light/fl_nc.py 82.35% <0.00%> (-4.61%) ⬇️
src/yadism/coefficient_functions/light/f2_nc.py 85.00% <0.00%> (-3.47%) ⬇️
src/yadism/coefficient_functions/fonll/fl_nc.py 78.08% <0.00%> (-2.17%) ⬇️
src/yadism/coefficient_functions/fonll/f2_nc.py 76.72% <0.00%> (-1.51%) ⬇️
...sm/coefficient_functions/fonll/partonic_channel.py 58.33% <0.00%> (-0.69%) ⬇️
src/yadism/esf/esf.py 48.71% <0.00%> (-0.65%) ⬇️
... and 21 more

@giacomomagni
Copy link
Collaborator

Hi Felix, I'll have check if I still have it installed...
I think we can merge #145, where some of the changes are already addressed
(my bad not having done it before...) is it okay ?

@felixhekhorn
Copy link
Contributor Author

With #145 in the main difference is that I used the eko compatibility layer always since Couplings is an eko object and we can't guarantee at the moment the yadism compatibility layer acts the same (see also #151)

@felixhekhorn felixhekhorn merged commit 9f46b63 into develop Sep 28, 2022
@felixhekhorn felixhekhorn deleted the update-eko-0.10 branch September 28, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants