Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition to new damping convention #142

Merged
merged 8 commits into from
Dec 7, 2023
Merged

Conversation

felixhekhorn
Copy link
Contributor

Closes #141

@felixhekhorn felixhekhorn added the bug Something isn't working label Dec 4, 2023
src/pineko/fonll.py Outdated Show resolved Hide resolved
src/pineko/fonll.py Outdated Show resolved Hide resolved
src/pineko/fonll.py Outdated Show resolved Hide resolved
@andreab1997
Copy link
Contributor

@felixhekhorn and @giacomomagni please have a look when you have time. Note that I also reworked a bit the checks that we do at the beginning.

src/pineko/fonll.py Outdated Show resolved Hide resolved
src/pineko/fonll.py Outdated Show resolved Hide resolved
src/pineko/fonll.py Outdated Show resolved Hide resolved
src/pineko/fonll.py Show resolved Hide resolved
@alecandido
Copy link
Member

Just a small note: I like a lot the idea of simplifying the FONLL handling. But even simplifications are changes, and changes are the opposite of stability.

Make sure to make careful checks before merging.

@andreab1997
Copy link
Contributor

Just a small note: I like a lot the idea of simplifying the FONLL handling. But even simplifications are changes, and changes are the opposite of stability.

Make sure to make careful checks before merging.

Yes sure, you are right, I am perfectly aware of the risks of reworking a code that works

@andreab1997
Copy link
Contributor

@felixhekhorn, @giacomomagni Can you please review this when you have time?

@andreab1997
Copy link
Contributor

I tried to reproduce the fktables with this branch and everything seem to work fine. @felixhekhorn when you are happy we can merge

@felixhekhorn
Copy link
Contributor Author

I trust you tested it in real life 🙃

@felixhekhorn felixhekhorn merged commit 054440a into main Dec 7, 2023
4 checks passed
@felixhekhorn felixhekhorn deleted the fix-damping-fonll-140 branch December 7, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix new DAMP convention
4 participants