-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix condition to new damping convention #142
Conversation
@felixhekhorn and @giacomomagni please have a look when you have time. Note that I also reworked a bit the checks that we do at the beginning. |
Just a small note: I like a lot the idea of simplifying the FONLL handling. But even simplifications are changes, and changes are the opposite of stability. Make sure to make careful checks before merging. |
Yes sure, you are right, I am perfectly aware of the risks of reworking a code that works |
@felixhekhorn, @giacomomagni Can you please review this when you have time? |
I tried to reproduce the fktables with this branch and everything seem to work fine. @felixhekhorn when you are happy we can merge |
I trust you tested it in real life 🙃 |
Closes #141