-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation of CMS_WCHARM_7TEV in the new format #2245
Conversation
This PR is still WIP. Here you can find a report of the new implementation, which is preliminary: report
|
e4bf77e
to
6a5cbb0
Compare
I have finalised the implementation of this dataset. Besides the new report posted in the description of this PR, I have the following comments:
Please, @RoyStegeman have a look at the implementation and let me know if you find something unclear or wrong. |
2ee81ed
to
5bc8d02
Compare
49ceae7
to
5e91ceb
Compare
d64a8fe
to
a4285c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for both WPWM-RATIO and WPWM-TOT:
- The
legacy
variant gives exactly the same chi2 between master and this branch. - WPWM-RATIO: Difference between legacy and new implementation is minimal
- WPWM-TOT: Difference between legacy and new implementation is minimal
I still want to go over the code but if it's similar to the previous one I'm sure that will be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good
0ab7d87
to
bd47a55
Compare
Comments
This dataset delivers two different observables:
The variant
sys_10
accounts for the 3pt prescription and thus it should be deprecated in the new format.Legacy: [default]
New: [default]