Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New implementation of CMS_WCHARM_13TEV_WPWM-TOT-UNNORM #2244
New implementation of CMS_WCHARM_13TEV_WPWM-TOT-UNNORM #2244
Changes from all commits
486e6c8
f19ed69
db6cb12
5a440b1
220300d
64148c1
06daacf
e74f01f
4e6a503
5e98fcf
db7524f
f79bed3
10575e9
831345f
b95aaf1
be779ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean to say here. The fact that
MW2
is the same for all bins is because it's a fixed parameter, whether it's used in the fit or not. Perhaps the point here is that even though it's fixed you still need to put the value in each bin because it's treated as a kinematic variable and the code needs to take those from the kinematics.yaml file (with the exception of sqrts, as you mentioned in the other comment)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I mean here is that MW2 is used only in the computation$(x,Q^2)$ -plane for the kinematic coverage. Contrary to the case of sqrts, MW2 is not deduced by the name of the dataset. So you're point is right: despite MW2 is a fixed parameter, the code still needs it.