Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

Feature: Notification Sound Effects #21

Merged
merged 19 commits into from
Jun 12, 2024

Conversation

Rumsie-Grimshaw
Copy link
Collaborator

This pull request is an attempt at audibly communicating to the user via sound notifications utilizing the sound files fount in app/static/audio.

This PR is currently in progress and all open discussion is welcomed.

Reference: Issue #20

@lowkw
Copy link

lowkw commented Jun 11, 2024

Kindly see my comments on the issue #20. Thanks.

…dplay_notifications and modified associated function calls.
@Rumsie-Grimshaw Rumsie-Grimshaw self-assigned this Jun 11, 2024
@Rumsie-Grimshaw Rumsie-Grimshaw force-pushed the feature/sound_effects branch from 5cd0539 to 4fde641 Compare June 11, 2024 14:11
@Rumsie-Grimshaw Rumsie-Grimshaw requested a review from lowkw June 11, 2024 16:55
Copy link

@lowkw lowkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. Thanks.

@lowkw lowkw marked this pull request as ready for review June 12, 2024 02:06
@lowkw lowkw merged commit f47d14b into NM-TAFE:main Jun 12, 2024
1 of 3 checks passed
@lowkw
Copy link

lowkw commented Jun 12, 2024

Thank you Rumsie

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants