This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
fix: resolved path issues using pathlib. fixes #12 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed current working directory and set default paths for out and videos
…he host system This requires updating due to using Ubuntu in GitHub workflows for testing.
Restored original implementations of serve_video and upload_video functions in app.py script.
VinhTDo
reviewed
Jun 4, 2024
VinhTDo
reviewed
Jun 4, 2024
|
All good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'm a CIV student trying to contribute to this project. If it's too late to join, you can cancel this PR.
This PR attempts to resolve the path issues using
pathlib. This should make it agnostic to any OS.