reorganize chapters: add technology guides section #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@egpbos You've requested our review, but it is still in draft. Would you like me to review this now? |
|
Yes, you can review. The only thing that I still want to do before merging is move the dataset chapter as well, after #339 is merged, that's why it's still in draft. |
bouweandela
previously requested changes
Sep 26, 2024
|
Good catch, updated the README. I would suggest to consider the Best Practices in another thread, because I'm not sure if we should completely remove it. |
|
Ah, we had that other thread already :P #321 |
egpbos
force-pushed
the
technology_guides
branch
from
074a1bf
to
17ada0a
Compare
Also moved language guides to the root folder level, because I find it annoying to have to click into the best_practices folder. Note: datasets still has to be moved to technologies, but there is an outstanding PR on that and I don't want to stress git's ability to detect moved files too much, otherwise we lose the ability to easily browse edit history.
egpbos
force-pushed
the
technology_guides
branch
from
17ada0a
to
9161825
Compare
|
Ok, I moved it down as you suggested after all. Otherwise the technology menu is too far down and it may not be noticed. |
c-martinez
approved these changes
Sep 30, 2024
|
Assuming @bouweandela is happy with the changes, since he suggested them ;) Merging! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
This PR adds the new section of technology guides and moves the GPU and UX chapters there.
Also moved language guides to the root folder level, because I find it annoying to have to click into the best_practices folder.
Note: datasets still has to be moved to technologies, but there is an outstanding PR #339 on that and I don't want to stress git's ability to detect moved files too much, otherwise we lose the ability to easily browse edit history.
Fixes #335.