Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolved page flickering - wait for page to fully load #206

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

JaimeFRF
Copy link
Contributor

Closes #172

  • Set a timeout probably does not always work depending on how good your connection is
  • Tried to enforce waiting for all the previous work to be done before displaying the page. Didn't solve the problem; which probably meant that with the timeout, we were giving time to the page itself to finish loading something
  • Now , explicitly saying : if the page is done loading show it ; if not addEventListener when "load" fires (the page is finished loading) now you can show it

@JaimeFRF JaimeFRF linked an issue Nov 15, 2024 that may be closed by this pull request
Copy link
Collaborator

@toni-santos toni-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's it! quite simple and should work everytime, good job 👍

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 🛫

@JaimeFRF JaimeFRF merged commit db9b38d into develop Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flickering on page load
3 participants