Ruff: Disallow unsafe fixes and revert changes. #303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
The ruff configuration in
pyproject.toml
containedpreview=true
, which enables certain checks (and potential fixes) that are very recent and potentially unstable. I applied some of those fixes in PR #297, instead of simply silencing the lines causing the warnings. This PR is the result of a review of those particular fixes.Steps taken
+
appear appropriate. For the last two marked with a-
I wasn't sure if they were causing a breaking check (nor did I check), so I marked the changes for reversal.pyproject.toml
configuration file to disable automatic fixes for rules with preview status.A PR will follow with updates to the
codespell
configuration.