Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better version extraction #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Better version extraction #90

wants to merge 2 commits into from

Commits on Mar 18, 2021

  1. cmake/generate_version_file: strip whitespace from version.txt contents 

    This avoids having to remember to use `echo -n` or other such bits.
    @mathstuf
    mathstuf committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    9d94294 View commit details
    Browse the repository at this point in the history

  2. cmake/generate_version_file: catch errors at the end 

    The directory-based extraction can fail if the directory was renamed
before netgen was configured (e.g., CMake's ExternalProject will
generally rename the top-level directory to `src` for consistency).

If the directory name extraction failed, an empty string ended up in the
binary which causes runtime failures when trying to parse as an integer.
    @mathstuf
    mathstuf committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    1020b99 View commit details
    Browse the repository at this point in the history