Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: extend nglib api #28

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

dyollb
Copy link

@dyollb dyollb commented Mar 1, 2019

This is work in progress. I am still in the process of testing the api. The api changes are backwards compatible, i.e. new arguments are optional.
Please feel free to comment, or give suggestions.

new features:

  • expose domain index
  • expose mesh optimization parameters
  • expose "STL mesh doctor" parameters
  • expose 2D geometries / 2D meshing
  • export meshes to VTK file format (2D/3D, including domain index)
  • options to make netgen quiet (send messages to null stream)

todo:

  • expose bc index
  • ... ?

dyollb and others added 12 commits February 27, 2019 20:32
add Ng_AddLockedPoint
extend API so user can set/get domain for element (optional -> does not break existing API)

the commit also (optionally) allows to send log messages (cout, cerr, testout) to a Null stream buffer. this allows applications to make netgen quiet
… meshing

- > add temporary file, where these functions are implemented
fix vtk writer for 2d meshes
extend vtk writer to write also domain index per cell
…e ids (surfnr, bcnr, domin, domout) via FaceDescriptor
@ChrLackner
Copy link
Member

The api is quite old and I think it would be better/easier to just build against the C++ code. Is there a reason why you do not want that?
Best
Christopher

@dyollb
Copy link
Author

dyollb commented May 31, 2019

@ChrLackner Do you mean I should directly link against ngcore, and directly use all the classes from the different parts of netgen, or would you use the nginterfaces.h interface instead? I don't think it supports all I need from nglib.h either.

I have for a long time been using the nglib interface with local modifications and wanted instead move those local changes to the main branch.

@ChrLackner
Copy link
Member

Yes I would suggest linking against the c++ libraries. If you want you can write me at [email protected] and we can work out a stable interface that supports what you need, but we would like to not expand the nglib api. It provides a very small and stable api, but since we do not test, improve and maintain it (or at least as less as possible) we want to keep it small. If we expand it we would need to keep it up to date (which we do not really have the resources for)
Best
Christopher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants