dp a more complete job of dynamically generating etc content #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns for etc generation.
…n of object names
dmjacobsen
changed the title
scanon
reviewed
Jan 3, 2020
|
I did add an integration test for the overall capability to assure it is functional, however the unittest for the _import_user function is not complete yet |
scanon
approved these changes
Jan 3, 2020
There was a problem hiding this comment.
More info from Doug out of band on what was causing the previous static generation to no longer being viable. I think it is largely site specific, but this mode could be useful to others. It also obviates the need to generate passwd/group files which is handy.
|
I think this is good enough so I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to try to correct #272