Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #244 #245

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Fix for Issue #244 #245

merged 3 commits into from
Mar 6, 2019

Conversation

scanon
Copy link
Member

@scanon scanon commented Feb 19, 2019

Imported images have an extra './' in the tar file paths. If a later
layer that builds on that import changes a directory to a file or link,
the paths will be different. So this normalizes the paths across all the
layers by stripping off any './' prefix.

It adds a test too.

Closes issue #244

Imported images have an extra './' in the tar file paths.  If a later
layer that builds on that import changes a directory to a file or link,
the paths will be different.  So this normalizes the paths across all the
layers by stripping off any './' prefix.

It adds a test too.
@scanon
Copy link
Member Author

scanon commented Mar 6, 2019

I'm going to self-merge this since it should be very safe and includes a test.

@scanon scanon merged commit eaf113c into NERSC:master Mar 6, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.65% when pulling 2b22f9a on scanon:issue244 into 4497d28 on NERSC:master.

@scanon scanon deleted the issue244 branch December 18, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants