Show only project users in Data Storage edit dialog #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshholland
force-pushed
the
ed-95-storage-project-users
branch
from
9a027ef to
36f1066
Compare
The refactor in 7ee1b20 means that neither of these methods are actually ever called.
jshholland
force-pushed
the
ed-95-storage-project-users
branch
from
36f1066 to
51b21a0
Compare
iwalmsley
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
This is really good thanks!
There used to be legacy actions whereby calls were instantly made to add/remove users as you interacted with this form - but that was changed to on apply - we can probably strip out a bunch more code and endpoints as a result e.g - https://github.com/NERC-CEH/datalab/blob/master/code/workspaces/web-app/src/actions/dataStorageActions.js#L38.
| @@ -1,96 +1,36 @@ | |||
| import React, { Component } from 'react'; | |||
| import React, { useEffect, useMemo } from 'react'; | |||
There was a problem hiding this comment.
Hadn't seen this before - really nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.