Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct liveness probe and init container dir setup #929

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix: correct liveness probe and init container dir setup #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions code/workspaces/infrastructure-api/resources/vscode.deployment.template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
image: busybox
imagePullPolicy: IfNotPresent
command: ["sh"]
args: ["-c", "mkdir -p /mnt/persistentfs/vscode/{{ name }}/workspace && mkdir -p /mnt/persistentfs/vscode/{{ name }}/conda"]
args: ["-c", "mkdir -p /mnt/persistentfs/notebooks/{{ name }}/workspace /mnt/persistentfs/notebooks/{{ name }}/conda /assets"]
volumeMounts:
- mountPath: /mnt/persistentfs
name: persistentfsvol
Expand All @@ -36,7 +36,7 @@ spec:
image: busybox
imagePullPolicy: IfNotPresent
command: ["sh"]
args: ["-c", "chmod 777 /mnt/persistentfs/notebooks && chmod 777 /mnt/persistentfs/vscode/{{ name }} && chmod 777 /mnt/persistentfs/vscode/{{ name }}/workspace && chmod 777 /mnt/persistentfs/vscode/{{ name }}/conda && ln -sfn /assets /mnt/persistentfs/vscode/{{ name }}/assets"]
args: ["-c", "chmod 777 /mnt/persistentfs/notebooks/{{ name }} /mnt/persistentfs/notebooks/{{ name }}/workspace /mnt/persistentfs/notebooks/{{ name }}/conda && ln -sfn /assets /mnt/persistentfs/notebooks/{{ name }}/assets"]
volumeMounts:
- mountPath: /mnt/persistentfs
name: persistentfsvol
Expand Down Expand Up @@ -69,11 +69,13 @@ spec:
cpu: 2
memory: 8Gi
livenessProbe:
httpGet:
path: {{{ basePath }}}
port: 3000
failureThreshold: 5
initialDelaySeconds: 5
periodSeconds: 10
successThreshold: 1
tcpSocket:
port: 3000
timeoutSeconds: 5
volumeMounts:
{{#volumeMount}}
- name: persistentfsvol
Expand Down
24 changes: 14 additions & 10 deletions ...rkspaces/infrastructure-api/src/kubernetes/__snapshots__/deploymentGenerator.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ spec:
image: busybox
imagePullPolicy: IfNotPresent
command: [\\"sh\\"]
args: [\\"-c\\", \\"mkdir -p /mnt/persistentfs/vscode/deployment-name/workspace && mkdir -p /mnt/persistentfs/vscode/deployment-name/conda\\"]
args: [\\"-c\\", \\"mkdir -p /mnt/persistentfs/notebooks/deployment-name/workspace /mnt/persistentfs/notebooks/deployment-name/conda /assets\\"]
volumeMounts:
- mountPath: /mnt/persistentfs
name: persistentfsvol
Expand All @@ -806,7 +806,7 @@ spec:
image: busybox
imagePullPolicy: IfNotPresent
command: [\\"sh\\"]
args: [\\"-c\\", \\"chmod 777 /mnt/persistentfs/notebooks && chmod 777 /mnt/persistentfs/vscode/deployment-name && chmod 777 /mnt/persistentfs/vscode/deployment-name/workspace && chmod 777 /mnt/persistentfs/vscode/deployment-name/conda && ln -sfn /assets /mnt/persistentfs/vscode/deployment-name/assets\\"]
args: [\\"-c\\", \\"chmod 777 /mnt/persistentfs/notebooks/deployment-name /mnt/persistentfs/notebooks/deployment-name/workspace /mnt/persistentfs/notebooks/deployment-name/conda && ln -sfn /assets /mnt/persistentfs/notebooks/deployment-name/assets\\"]
volumeMounts:
- mountPath: /mnt/persistentfs
name: persistentfsvol
Expand Down Expand Up @@ -839,11 +839,13 @@ spec:
cpu: 2
memory: 8Gi
livenessProbe:
httpGet:
path: /
port: 3000
failureThreshold: 5
initialDelaySeconds: 5
periodSeconds: 10
successThreshold: 1
tcpSocket:
port: 3000
timeoutSeconds: 5
volumeMounts:
- name: persistentfsvol
mountPath: /data
Expand Down Expand Up @@ -883,7 +885,7 @@ spec:
image: busybox
imagePullPolicy: IfNotPresent
command: [\\"sh\\"]
args: [\\"-c\\", \\"mkdir -p /mnt/persistentfs/vscode/deployment-name/workspace && mkdir -p /mnt/persistentfs/vscode/deployment-name/conda\\"]
args: [\\"-c\\", \\"mkdir -p /mnt/persistentfs/notebooks/deployment-name/workspace /mnt/persistentfs/notebooks/deployment-name/conda /assets\\"]
volumeMounts:
- mountPath: /mnt/persistentfs
name: persistentfsvol
Expand All @@ -893,7 +895,7 @@ spec:
image: busybox
imagePullPolicy: IfNotPresent
command: [\\"sh\\"]
args: [\\"-c\\", \\"chmod 777 /mnt/persistentfs/notebooks && chmod 777 /mnt/persistentfs/vscode/deployment-name && chmod 777 /mnt/persistentfs/vscode/deployment-name/workspace && chmod 777 /mnt/persistentfs/vscode/deployment-name/conda && ln -sfn /assets /mnt/persistentfs/vscode/deployment-name/assets\\"]
args: [\\"-c\\", \\"chmod 777 /mnt/persistentfs/notebooks/deployment-name /mnt/persistentfs/notebooks/deployment-name/workspace /mnt/persistentfs/notebooks/deployment-name/conda && ln -sfn /assets /mnt/persistentfs/notebooks/deployment-name/assets\\"]
volumeMounts:
- mountPath: /mnt/persistentfs
name: persistentfsvol
Expand Down Expand Up @@ -926,11 +928,13 @@ spec:
cpu: 2
memory: 8Gi
livenessProbe:
httpGet:
path: /
port: 3000
failureThreshold: 5
initialDelaySeconds: 5
periodSeconds: 10
successThreshold: 1
tcpSocket:
port: 3000
timeoutSeconds: 5
volumeMounts:
- name: persistentfsvol
mountPath: /data
Expand Down
Loading