New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing web app settings to use custom domain #925

Merged

iwalmsley merged 2 commits into master from ed-37-web-app-use-custom-domain

Nov 17, 2023

Contributor

o2a commented Nov 15, 2023

PR for changes to datalab web app to use the new custom domain


          changing web app settings to use custom domain

cb55ce6

o2a requested a review from iwalmsley

November 15, 2023 14:06

iwalmsley requested changes

View reviewed changes

Contributor

iwalmsley left a comment

LGTM but would it be possible to re-run the snapshots to get the tests passing?


          chore: updating the snapshots for auth-service and web app

0b65e7d

iwalmsley approved these changes

View reviewed changes

iwalmsley merged commit 30824e9 into master

6 checks passed

iwalmsley deleted the ed-37-web-app-use-custom-domain branch

November 17, 2023 08:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet