Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to extlinks for compatibility with Sphinx 6 #180

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

kafitzgerald
Copy link
Collaborator

@kafitzgerald kafitzgerald commented Nov 20, 2023

PR Summary

Sphinx 6+ broke compatibility with how we had extlinks configured.

Closes #179

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.

@kafitzgerald kafitzgerald added bug Something isn't working documentation Improvements or additions to documentation labels Nov 20, 2023
@kafitzgerald kafitzgerald marked this pull request as ready for review November 20, 2023 23:24
@kafitzgerald kafitzgerald merged commit 21a18e5 into NCAR:main Nov 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link check is failing w/ Sphinx update
2 participants