Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove matplotlib version pin #177

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Conversation

kafitzgerald
Copy link
Collaborator

@kafitzgerald kafitzgerald commented Nov 16, 2023

PR Summary

Remove matplotlib version pin now that most contour labeling issues have been addressed upstream (e.g. matplotlib/matplotlib#27045)

Also thins the number of contour labels added to the plot_contour_labels usage example to make it look a bit cleaner and remove problematic locations that hit upon the remaining bug in matplotlib contour labeling.

We could opt to leave some of these problematic locations in and wait until there's a fix in matplotlib to remove the version pin, but geocat-examples will still catch this particular issue. Given that this is a bit of a an edge case, I think the benefit of removing the version pin from geocat-viz at this point outweighs the risk to users.

Closes #160

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.

@kafitzgerald kafitzgerald changed the title Issue160 Remove matplotlib version pin Nov 16, 2023
@kafitzgerald kafitzgerald marked this pull request as ready for review November 16, 2023 18:22
@kafitzgerald kafitzgerald requested a review from jukent November 16, 2023 18:23
@kafitzgerald
Copy link
Collaborator Author

Apparently the link for mamba installation instructions changed and that's what the link checker caught.

I'll just update that in here as well.

@kafitzgerald kafitzgerald merged commit 7d9926c into NCAR:main Nov 16, 2023
9 checks passed
@kafitzgerald kafitzgerald deleted the issue160 branch November 16, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove matplotlib 3.8+ pin
2 participants