Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Remove matplotlib version pin now that most contour labeling issues have been addressed upstream (e.g. matplotlib/matplotlib#27045)
Also thins the number of contour labels added to the
plot_contour_labels
usage example to make it look a bit cleaner and remove problematic locations that hit upon the remaining bug in matplotlib contour labeling.We could opt to leave some of these problematic locations in and wait until there's a fix in matplotlib to remove the version pin, but geocat-examples will still catch this particular issue. Given that this is a bit of a an edge case, I think the benefit of removing the version pin from geocat-viz at this point outweighs the risk to users.
Closes #160
PR Checklist
General
closes #XXX
to the PR description where XXX is the number of the issue.docs/release-notes.rst
in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecatedprecommit
. To set up on your local, runpre-commit install
from the top level of the repository. To manually run pre-commits, usepre-commit run --all-files
and re-add any changed files before committing again and pushing.