Skip to content

Commit

Permalink
Update pre-commit (#247)
Browse files Browse the repository at this point in the history
* Update .pre-commit-config.yaml versions and add pre-commit.ci with autoupdate

* remove old pre-commit workflow that has been replace by pre-commit.ci

* update release notes

* adjust yapf config temporarily because of yapf issue #1164

* formatting
  • Loading branch information
kafitzgerald authored Oct 8, 2024
1 parent 8c4edcc commit 29b89f6
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 22 deletions.
15 changes: 0 additions & 15 deletions .github/workflows/pre-commit.yml

This file was deleted.

16 changes: 11 additions & 5 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,22 +1,28 @@
repos:
- repo: https://github.com/pre-commit/mirrors-yapf # To format the code to conform YAPF
rev: v0.31.0
- repo: https://github.com/google/yapf # To format the code to conform YAPF
rev: v0.40.2
hooks:
- id: yapf
args: ['--in-place', '--recursive', '--style', 'google']
require_serial: true

- repo: https://github.com/myint/docformatter # To format the doc strings to conform PEP257
rev: v1.4
- repo: https://github.com/PyCQA/docformatter # To format the doc strings to conform PEP257
rev: v1.7.5
hooks:
- id: docformatter
args: [--in-place]

- repo: https://github.com/pre-commit/pre-commit-hooks # Some common pre-commit hooks
rev: v3.4.0
rev: v4.6.0
hooks:
- id: check-yaml # Checks the syntax of .yaml files.
args: [--allow-multiple-documents]
exclude: 'meta.yaml' # Exclude this because it gives an error for '%' in Line 1 and couldn't fix yet
- id: end-of-file-fixer # Makes sure files end with a newline.
- id: trailing-whitespace # Checks for any tabs or spaces after the last non-whitespace character on the line.
- id: check-docstring-first # Checks that code comes after the docstrings.
- id: check-yaml # Check valid yml file

ci:
autofix_prs: false
autoupdate_schedule: monthly
3 changes: 2 additions & 1 deletion docs/release-notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@
Release Notes
=============

v2024.07.0 (unreleased)
v2024.xx.0 (unreleased)
---------------------------

Internal Changes
^^^^^^^^^^^^^^^^
* Update pre-commit versions and configuration by `Katelyn FitzGerald`_ in (:pr:`247`)
* Remove M1 workaround for CI and tokens that are no longer needed by `Katelyn FitzGerald`_ in (:pr:`232`)

Testing
Expand Down
3 changes: 2 additions & 1 deletion src/geocat/viz/taylor.py
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,8 @@ def add_ygrid(self,
*arr*.
This method will be deprecated in favor of `TaylorDiagram.add_std_grid()`
This method will be deprecated in favor of
`TaylorDiagram.add_std_grid()`
"""

warnings.warn(
Expand Down

0 comments on commit 29b89f6

Please sign in to comment.