Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constituent bugfixes #608

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Constituent bugfixes #608

merged 10 commits into from
Nov 5, 2024

Conversation

peverwhee
Copy link
Collaborator

@peverwhee peverwhee commented Oct 31, 2024

Fixes a couple of small bugs in the constituents object

  1. Add missing units field to equivalence check and constituent copy
  2. Add missing fields to instantiate call
  3. Parse mixing ratio type from standard name correctly (if "mixing_ratio_type" not provided to instantiate)
  4. Add check of errflg in register to return before allocating if there's an error

User interface changes?: No

Fixes #587

Testing:
test removed: N/A
unit tests: All pass
system tests: All pass; modified advection test to check new instantiate fields
manual testing: Run w/ register phase in CAM-SIMA

@climbfuji
Copy link
Collaborator

I approve (still no "approve" button on my machine)

Copy link
Collaborator

@mwaxmonsky mwaxmonsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @peverwhee, looks great to me!

src/ccpp_constituent_prop_mod.F90 Outdated Show resolved Hide resolved
@peverwhee peverwhee merged commit bcc3aba into NCAR:develop Nov 5, 2024
19 checks passed
mkavulich pushed a commit that referenced this pull request Nov 7, 2024
Fixes bug introduced by me in #608. Use variable errflg name instead of
"errflg" explicitly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants