Prelim GDAL enabled PIO #1980
Prelim GDAL enabled PIO #1980
Conversation
shapefile read issue. MSL
There was a problem hiding this comment.
It looks like your branch is missing some history and you are trying to bring back a lot of old code - please clean that up and only bring in your intended changes. It also looks like you are trying to run the interface to gdal on all io tasks when it should only be run on io_root. When you have made these changes I'll take another look.
| @@ -9,8 +9,8 @@ project (PIOC C) | |||
| if (CMAKE_BUILD_TYPE) | |||
| define_property( | |||
| SOURCE | |||
| PROPERTY COMPILE_FLAGS | |||
| INHERITED | |||
| PROPERTY COMPILE_FLAGS | |||
There was a problem hiding this comment.
avoid adding unneeded whitespace.
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * c.f.: https://raw.githubusercontent.com/rabauke/mpl/main/examples/parallel_sort_mpi.c | |||
| * c.f.: https://raw.githubusercontent.com/rabauke/mpl/master/examples/parallel_sort_mpi.c | |||
| int ierr; | ||
| if ((mpierr = MPI_Comm_rank(comm, &rank))) | ||
| check_mpi(NULL, NULL, mpierr, __FILE__, __LINE__); | ||
| check_mpi(NULL, NULL, mpierr2, __FILE__, __LINE__); |
There was a problem hiding this comment.
This is wrong, mpierr is an input to check_mpi.
| @@ -17,16 +17,9 @@ | |||
| #include <uthash.h> | |||
|
|
|||
| #include <netcdf.h> | |||
| #include <netcdf_meta.h> | |||
|
|
||
| #include <gdal.h> | ||
| //#include <ogr_api.h> |
There was a problem hiding this comment.
Why the commented include?
| (*pio_type)[v] = (int)PIO_STRING; | ||
| (*pio_type_size)[v] = -1; | ||
| break; | ||
| // This needs to be done. How do we deal with timestamps etc in GDAL vector fields? |
There was a problem hiding this comment.
Can we treat them as separate variables?
| { | ||
| if (!ios->ioproc) | ||
| { | ||
| int msg = PIO_MSG_INQ_VARID; |
There was a problem hiding this comment.
You will need to define unique msg id's for your functions, this is part of the async support.
| switch (file->iotype) | ||
| { | ||
| case PIO_IOTYPE_GDAL: | ||
| // if (ios->io_rank == 0) |
There was a problem hiding this comment.
Why is this commented out? If your IO is limited to a serial interface you only want to open the file on the root io task.
| return pio_err(NULL, NULL, ierr, __FILE__, __LINE__); | ||
|
|
||
| GDALDatasetH *hDS = file->hDS; | ||
| OGRLayerH hLayer = OGR_DS_GetLayer( hDS, 0 ); |
There was a problem hiding this comment.
shouldn't this also be limited to io_root?
| case PIO_IOTYPE_GDAL: | ||
| PLOG((2, "Calling GDALCreate io_comm = %d mode = %d fh = %d", | ||
| ios->io_comm, mode, file->fh)); | ||
|
|
There was a problem hiding this comment.
I think that these calls should be restricted to io_root.
|
Superseded by #1981 |
Created for diagnosis of shapefile read issue.
MSL