Adding a few rof notebooks #126
Merged
Task list completed / task-list-completed
succeeded
Nov 21, 2024 in 0s
19 / 19 tasks completed
All tasks have been completed
Details
Required Tasks
| Task | Status |
|---|---|
Have you followed the guidelines in our Contributor's Guide (including the pre-commit check)? |
Completed |
| Have you checked to ensure there aren't other open Pull Requests for the same update/change? | Completed |
| Does your submission pass tests? | Completed |
| Have you lint your code locally prior to submission? | Completed |
| Have you added an explanation of what your changes do and why you'd like us to include them? | Completed |
| Have you successfully tested your changes locally? | Completed |
update readme to include 'rof' on line 104: -rof, --river-runoff Run river runoff component diagnostics |
Completed |
| It looks like this is failing the pre-commit style checks | Incomplete |
I noticed in month_annual_flow.ipynb you have a logical flag parallel that enables using PBSCluster when set to true. If you look at examples/nblibrary/ocn/ocean_surface.ipynb you'll see how CUPiD already passes a serial flag and uses a LocalCluster when that is set to false... I haven't looked at the other runoff notebooks, but we need to avoid casper- or derecho-specific blocks of code |
Incomplete |
The notebooks in examples/nblibrary/rof should not have any output in them |
Incomplete |
replaced PBSCluster with LocalCluster, then follow the example in ocn notebook (use serial logical flag) |
Completed |
| activated cupid-dev and then Installed pre-commit under CUPiD/.git/hook. | Completed |
| clear outputs from all the cells. | Completed |
| add key_metrics/config.yml and modify case:grid input. | Completed |
| implement comparison with base_case in addition to obs | Completed |
| remove years that overwrite config file start/end years | Completed |
| include analysis-period configuration parameter to specify e.g. 10 years so that users don't need to run 100 years unless they really want to do so. | Completed |
| test cupid-run from key_metrics directory | Completed |
| implement comparison with base_case in addition to obs | Completed |
| remove years that overwrite config file start/end years | Completed |
| include analysis-period configuration parameter to specify e.g. 10 years so that users don't need to run 100 years unless they really want to do so. | Completed |
| test cupid-run from key_metrics directory | Completed |
Cell [14] (in 3.2. Annual cycle (at monthly step)) is the last cell that produces output; cells 15 - 21 have the %%time output but no plots or tables |
Incomplete |
| Did some metadata cells get moved around? I see the following sections in order: | Incomplete |
| Anaysis for all 922 sites | |
| 3.1 Compute metris at all the sites (no plots nor tables) | |
| 4.2. Spatial metric map | |
| 4.3 Boxplots of Error metrics (RMSE, %bias, and correlation coefficient) | Incomplete |
Cell [14] (in 3.2. Annual cycle (at monthly step)) is the last cell that produces output; cells 15 - 21 have the %%time output but no plots or tables |
Incomplete |
Loading