Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new flag for --target directories #180

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Add new flag for --target directories #180

merged 2 commits into from
Jan 8, 2025

Conversation

jordanpadams
Copy link
Member

🗒️ Summary

Functionality already existed using positional arguments. Updated the code to use an explicit flag.

⚙️ Test Data and/or Report

Local testing executed successfully.

DATA_PATHS="/home/pds4/edwg/data/pds4/context-pds4/investigation/working /home/pds4/edwg/data/pds4/context-pds4/instrument_host/working"
$HARVEST_SOLR_HOME/bin/harvest-solr -c $HARVEST_SOLR_CONFIG      -o $PDS4_SOLR_DOC_HOME --target $DATA_PATHS
...
Success!

♻️ Related Issues

resolves #179

@jordanpadams
Add new flag for --target directories
9bb7d30 
Functionality already existed using positional arguments. Updated the code to use an explicit flag.

resolves #179
@jordanpadams jordanpadams requested a review from a team as a code owner December 31, 2024 19:27
nutjob4life
nutjob4life approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual inspection: ✓
Run: ✓

$ ./harvest-legacy-4.4.0-SNAPSHOT/bin/harvest-solr --help | egrep -e --target
 -t,--target <dir>            Specify one or more target directories containing

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jordanpadams jordanpadams merged commit 2143ee6 into main Jan 8, 2025
3 checks passed
@jordanpadams jordanpadams deleted the i179 branch January 8, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nutjob4life nutjob4life nutjob4life approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a user, I want to provide a data input path via command-line
2 participants
@jordanpadams @nutjob4life