Version 1.5.0 #33
Merged
Version 1.5.0 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tloubrieu-jpl
commented
Feb 13, 2024
|
|
||
| def test_all_collections_of_a_bundle_as_deep_archive_does(self): | ||
|
|
||
| def get_collections(bundle_lidvid): |
There was a problem hiding this comment.
Hi @nutjob4life ,
This is the piece of code which tested the pagination as you do in deep-archive.
I will add a reference to here in the deep-archive ticket. Unfortunatly, I missed to commit the previous version of this code, so it will not be as easy for you to see the changes.
tloubrieu-jpl
force-pushed
the
version_140
branch
from
5adfe59 to
8e19bd4
Compare
nutjob4life
approved these changes
Feb 28, 2024
|
@tloubrieu-jpl do we still need this PR? Are we ready for merge? |
|
Yes @jordanpadams I merged it. I introduced mistakes last week or the week before in this branch when I tried to fix another issue, but I moved back the head since and this is now good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Upgrade the pagination parameters.