Properly set the ops:Harvest_Info/ops:node_name values, remove obsolete node_name in configuration file #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tloubrieu-jpl
requested changes
Oct 3, 2024
| @@ -59,8 +60,7 @@ static public List<String> exchangeLidvids (List<CollectionType> ids) { | |||
| } | |||
| static public String exchangeIndexForNode (String indexName) { | |||
| if (indexNodeMap.containsKey (indexName)) return indexNodeMap.get(indexName); | |||
| if (0 < indexName.indexOf("-registry")) return indexName.substring(0, indexName.indexOf("-registry")); | |||
| return "development"; | |||
| throw new IllegalArgumentException("Index (" + indexName + ") + not supported: either fix it in your configuration by using one of the supported or request an upgrade of harvest"); | |||
There was a problem hiding this comment.
Thanks @al-niessner, I would like the error message to provide the github issue link where the user can request for the upgrade needed, you can add to the message: " to support your new index by submitting a ticket on https://github.com/NASA-PDS/harvest/issues".
cut and pasted the string in there for ya
tloubrieu-jpl
approved these changes
Oct 8, 2024
tloubrieu-jpl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Just a quick typo change. More to come.
⚙️ Test Data and/or Report
NA
♻️ Related Issues
Closes #186
Closes #187