-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature to allow harvest to set archive status #161
Conversation
registry-common changed to go from hard coded value to a parameter. Changes in this commit support the new parameter all the way to the CLI.
Added the option to set the archive tested. Tested with certified and it worked. Also tested with fred and it failed as not legal.
@al-niessner is there any kind of integration tests we could add to the our registry test suite to verify the setting of archive status upon loading of the data? |
We could add a trivial test that show that the default variable is updated. Not sure that does much but could offer a very modest amount of regression. Otherwise back to needing a running opensearch, secrets, test data, expectations that change with the data etc. |
@al-niessner thanks. I don’t think a test like that is necessary worth it. I will try to test this over the weekend. |
@al-niessner @jordanpadams, I suspect we will encounter the same issue that we are having on NASA-PDS/registry-mgr#82 (comment) But for now I am having a different issue:
@al-niessner is that something you can reproduce ? Thanks |
This is about harvest not registry-mgr. Not sure if something is wrong in your environment or just putting messages in different PRs. |
Sorry @al-niessner, I was confused about what the PR was for. I will test that again, more appropriately. |
I was finally able to validate that new development by manual test on MCP Dev account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works perfectly on MCP Dev.
Thanks @al-niessner
🗒️ Summary
Allow harvest to define the archive status when it harvests the data.
⚙️ Test Data and/or Report
Validated by setting to certified and looked in DB. Also tried with fred and it failed giving a list of valid choices.
♻️ Related Issues
Closes #135
Requires NASA-PDS/registry-common#56