Fixing Speckling Issues in MR #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration to address speckling issues in MR
1. Code changed to use the last (unperturbed) ensemble member, rather than hardwiring to 12. 2. Renamed option to "unperturbed sampling". 3. Updated documentation. Output restart files still match the samples provided by Yeosang Yoon. I still need to test run with LIS, but I do not anticipate a problem.
|
Successfully reproduced provided LDT and LIS test cases (after renaming "557ww" option to "unperturbed sampling", and adjusting the LIS batch job script for better resource usage -- also, LIS 7.6 was used to produce the test LIS results). I am satisfied with this code, and will accept the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented an additional sampling strategy for ensemble restart generation to address speckling issues in MR.
Resolves #1606
'ldt.config'
Ensemble restart generation sampling strategy: "557ww" # option: none, random sampling, 557ww
Testcase
LDT
/discover/nobackup/yyoon4/lis7/Testcase/speckling/ldt/ldt.config.global.noah39.ensemble
LIS
/discover/nobackup/yyoon4/lis7/Testcase/speckling/lis/lis.config.global.noah39.hymap.galwem