Store selected exploration datasets on url #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I am not sure why, but the preview throws a critical error: https://deploy-preview-708--veda-ui.netlify.app/exploration (I don't see this problem on my local.) |
danielfdsilva
force-pushed
the
feature/url-dataset
branch
from
0b124b1 to
791d12b
Compare
|
@hanbyul-here @sandrahoang686 Rebased this on top of the current exploration so the error is gone. Should be ready to review. |
hanbyul-here
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By storing the selected datasets in the url we allow the user to share the page state, although for it to be truly shareable there are other things that also need to be stored, which is not the main purpose of this PR.
The main goal here it to be able to give the user an entry point to the exploration page, when coming from the dataset catalog - not implemented in this PR