Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove LinkProperties from PageHeader in favor of VedaUIProvider #1382

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sandrahoang686
Copy link
Collaborator

@sandrahoang686 sandrahoang686 commented Jan 15, 2025

Related Ticket: #1381
Related PRs: developmentseed/next-veda-ui#36

Description of Changes

  • Removed LinkProperties prop from PageHeader and down the tree.
  • Abstracted VedaUIProvider wrapper out so it can also wrap around tests
  • Updated tests

Notes & Questions About Changes

{Add additonal notes and outstanding questions here related to changes in this pull request}

Validation / Testing

  • Make sure pageheader navigation is working as expected

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 1dcb3ab
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/67881f4912ab530008277f5e
😎 Deploy Preview https://deploy-preview-1382--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sandrahoang686 sandrahoang686 changed the title Remove LinkProperties from PageHeader in favor of VedaUIProvider chore: Remove LinkProperties from PageHeader in favor of VedaUIProvider Jan 15, 2025
@sandrahoang686 sandrahoang686 marked this pull request as ready for review January 15, 2025 18:25
Copy link
Contributor

@vgeorge vgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandrahoang686 the page navigation seems to be working well. I would suggest using a more descriptive name for the wrapper, like VedaUIConfigProvider. Alternatively, we could move it to the test/utils.js file as an exclusive wrapper for tests with an skeleton config to ensure no environment variables are passed to the tests unless we explicitly want them to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants