-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove LinkProperties from PageHeader in favor of VedaUIProvider #1382
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandrahoang686 the page navigation seems to be working well. I would suggest using a more descriptive name for the wrapper, like VedaUIConfigProvider
. Alternatively, we could move it to the test/utils.js
file as an exclusive wrapper for tests with an skeleton config to ensure no environment variables are passed to the tests unless we explicitly want them to be.
Related Ticket: #1381
Related PRs: developmentseed/next-veda-ui#36
Description of Changes
LinkProperties
prop from PageHeader and down the tree.Notes & Questions About Changes
{Add additonal notes and outstanding questions here related to changes in this pull request}
Validation / Testing