Fix issue 451

[amarouane-ABDELHAK]

Why are you creating this Pull Request?

• To fix the issue described here

[netlify]

✅ Deploy Preview for visex ready!

Name	Link
🔨 Latest commit	5f9c95f
🔍 Latest deploy log	https://app.netlify.com/sites/visex/deploys/670d2bb888e01f00079ddf61
😎 Deploy Preview	https://deploy-preview-452--visex.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[amarouane-ABDELHAK]

@hanbyul-here @anayeaye and I were wondering why we didn't use Domain_PROD as a relative path instead of a hardcoded domain name, if both work. Do you know the reason behind having the Domain_PROD variable as a full URL?

[hanbyul-here]

Thanks for working on the fix. The variable is used to specify where the bundled assets are served.
where it is passed to be used for application base url: (

veda-config/.github/workflows/deploy-prod.yml

Line 65 in 8654ea1

run: PUBLIC_URL="${{ env.DOMAIN_PROD }}" yarn build

)
The absolute path should work in theory, but I am honestly unsure if I am missing anything and if this change will bring unexpected outcomes.

As far as I know, we don't have a staging environment for earthdata.nasa.gov to test the URL change. Considering earthdata.nasa.gov has low traffic, should we just test on the production? or do you have any idea how we can test this change to not introduce any unexpected outcome without deploying it to production?

[amarouane-ABDELHAK]

I have build it locally with PUBLIC_URL as a path instead of URL and did not notice any side effect

[hanbyul-here]

thanks for working on it