-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content: Aerosol Discovery #262
Conversation
… not. The .jpg images are some of the data images that were created for this story. Let me know if there is something that is missing or something that I have done wrong.
✅ Deploy Preview for visex ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
… not. The .jpg images are some of the data images that were created for this story. Let me know if there is something that is missing or something that I have done wrong.
This PR is based on an outdated UI dashboard module, which is probably why the preview build is failing. I created the same pr, but based on the latest dashboard change : #265 (You can take over the new PR if you would like.) |
datasets/aerosol-dataset.data.mdx
Outdated
src: ::file ./smog-national-geographic-cover.jpg | ||
alt: Smog over a city. | ||
author: | ||
name: Trent Cowan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attribution here is for the photographer of the image, not the write-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the url doesn't match either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL seems to be working on my end. It sends me to the page where I found the smokestack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for smog-national-geographic-cover.jpg
although it doesn't even match the other image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, I see this is the dataset. Just fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete all the images that you are no longer using
@WeathermanTrent make sure you're following everything in the checklist |
This is complete. Do I close the pull request? |
Code-wise, this pr looks good to me now. Let me know when you get a green light for the contents, we can work on squeezing the changes so we have a neat git history. (Not sure who is the best person for content review. @j08lue, who is the best person to review this discovery content?) Discovery link: https://deploy-preview-262--visex.netlify.app/discoveries/houston-aod |
Great to see this! One thing that would be great to add are the taxonomies -
Can you nominate someone who can approve this content to go public, @WeathermanTrent? Otherwise, let us post this in the VEDA Slack channel and see who is eligible, perhaps pinging @deborahUAH. |
I can add those changes! When you say nominate someone, should I nominate @slesaad or @hanbyul-here ? Is that what you mean? |
No, I meant someone at NASA to can offer scientific quality assurance and, most importantly, programmatic approval (that this content is ok to publish under IMPACT's name). If in doubt, let's ask @deborahUAH. |
Ahh, I see! Asking @deborahUAH would be best then. |
Review is now in progress. Sounds like there will be more iterations on the content, @hanbyul-here. I'll make sure we get a ping when all is ready. |
We are making a couple final touches to the introduction. |
@WeathermanTrent this is just to let you know that we are working on creating a tool that should make editing these MDX files a lot easier - at least give you an a lot faster feedback loop compared to the CI builds. Basically, you will see MDX changes render live while you make them. Sorry we did not have it ready before you had to go through all of these edits... We will keep you posted on when this tool will be available to you. Let us know when your discovery is ready for review (by IMPACT reviewers and then someone from the dev team). |
Oops, missed the ping there about the story being ready. 🎉 @brianmfreitag, I take it the story, as it is shown here, has been reviewed and is ready for publication. I asked @hanbyul-here for a pro-forma / technical review and then we can merge and ship it with our next push to production, which we can prepare for right away. |
@j08lue @hanbyul-here - yes. The data story has been reviewed and is ready for publication to the dashboard. |
77227d6
to
087654f
Compare
Co-authored-by: WeathermanTrent <[email protected]> Co-authored-by: Brian Freitag <[email protected]>
087654f
to
3d031e0
Compare
Adding content
Working with Aerosol Optical Depth data.
Content checklist
Check the Content Documentation for more details.
Any content
Datasets
Discoveries