Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content: Aerosol Discovery #262

Merged
merged 22 commits into from
Oct 30, 2023
Merged

Content: Aerosol Discovery #262

merged 22 commits into from
Oct 30, 2023

Conversation

WeathermanTrent
Copy link
Collaborator

@WeathermanTrent WeathermanTrent commented May 18, 2023

Adding content

Working with Aerosol Optical Depth data.


Content checklist

Check the Content Documentation for more details.

Any content

  • Cover image with proper attribution (when relevant) is present.
  • Cover images do not contain any text (they're used as a background and text may not be readable).
  • All images are not too big/heavy. As a general rule of thumb, they should not weigh more than 500KB, or be larger than 2000px. See the media guide for more info.
  • Content was added using the available MDX Blocks.

Datasets

Discoveries

… not. The .jpg images are some of the data images that were created for this story. Let me know if there is something that is missing or something that I have done wrong.
@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 3d031e0
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/653fd603012a460008a58d29
😎 Deploy Preview https://deploy-preview-262--visex.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hanbyul-here
Copy link
Collaborator

This PR is based on an outdated UI dashboard module, which is probably why the preview build is failing. I created the same pr, but based on the latest dashboard change : #265 (You can take over the new PR if you would like.)

src: ::file ./smog-national-geographic-cover.jpg
alt: Smog over a city.
author:
name: Trent Cowan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attribution here is for the photographer of the image, not the write-up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the url doesn't match either

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL seems to be working on my end. It sends me to the page where I found the smokestack.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for smog-national-geographic-cover.jpg
although it doesn't even match the other image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I see this is the dataset. Just fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete all the images that you are no longer using

@slesaad
Copy link
Member

slesaad commented May 23, 2023

@WeathermanTrent make sure you're following everything in the checklist

@WeathermanTrent
Copy link
Collaborator Author

This is complete. Do I close the pull request?

@hanbyul-here
Copy link
Collaborator

Code-wise, this pr looks good to me now. Let me know when you get a green light for the contents, we can work on squeezing the changes so we have a neat git history. (Not sure who is the best person for content review. @j08lue, who is the best person to review this discovery content?)

Discovery link: https://deploy-preview-262--visex.netlify.app/discoveries/houston-aod

@j08lue
Copy link
Contributor

j08lue commented Jun 21, 2023

Great to see this!

One thing that would be great to add are the taxonomies - sources and thematics. Could you still add those, please @WeathermanTrent? The docs on that are here: https://github.com/NASA-IMPACT/veda-ui/blob/main/docs/content/TAXONOMY.md

who is the best person for content review

Can you nominate someone who can approve this content to go public, @WeathermanTrent? Otherwise, let us post this in the VEDA Slack channel and see who is eligible, perhaps pinging @deborahUAH.

@WeathermanTrent
Copy link
Collaborator Author

I can add those changes! When you say nominate someone, should I nominate @slesaad or @hanbyul-here ? Is that what you mean?

@j08lue j08lue mentioned this pull request Jun 21, 2023
@j08lue
Copy link
Contributor

j08lue commented Jun 21, 2023

No, I meant someone at NASA to can offer scientific quality assurance and, most importantly, programmatic approval (that this content is ok to publish under IMPACT's name). If in doubt, let's ask @deborahUAH.

@WeathermanTrent
Copy link
Collaborator Author

No, I meant someone at NASA to can offer scientific quality assurance and, most importantly, programmatic approval (that this content is ok to publish under IMPACT's name). If in doubt, let's ask @deborahUAH.

Ahh, I see! Asking @deborahUAH would be best then.

@j08lue
Copy link
Contributor

j08lue commented Jun 22, 2023

Review is now in progress. Sounds like there will be more iterations on the content, @hanbyul-here. I'll make sure we get a ping when all is ready.

@WeathermanTrent
Copy link
Collaborator Author

We are making a couple final touches to the introduction.

@j08lue
Copy link
Contributor

j08lue commented Jul 31, 2023

@WeathermanTrent this is just to let you know that we are working on creating a tool that should make editing these MDX files a lot easier - at least give you an a lot faster feedback loop compared to the CI builds. Basically, you will see MDX changes render live while you make them. Sorry we did not have it ready before you had to go through all of these edits... We will keep you posted on when this tool will be available to you.

Let us know when your discovery is ready for review (by IMPACT reviewers and then someone from the dev team).

@freitagb
Copy link
Collaborator

@aboydnw @j08lue - we've gotten approval to publish this story. What's the next step for getting this into production?

@j08lue j08lue requested a review from hanbyul-here October 5, 2023 20:00
@j08lue
Copy link
Contributor

j08lue commented Oct 5, 2023

Oops, missed the ping there about the story being ready. 🎉

@brianmfreitag, I take it the story, as it is shown here, has been reviewed and is ready for publication.

I asked @hanbyul-here for a pro-forma / technical review and then we can merge and ship it with our next push to production, which we can prepare for right away.

@freitagb
Copy link
Collaborator

@j08lue @hanbyul-here - yes. The data story has been reviewed and is ready for publication to the dashboard.

Co-authored-by: WeathermanTrent <[email protected]>
Co-authored-by: Brian Freitag <[email protected]>
@danielfdsilva danielfdsilva force-pushed the aerosol-discovery-trent branch from 087654f to 3d031e0 Compare October 30, 2023 16:12
@danielfdsilva danielfdsilva self-requested a review October 30, 2023 16:16
@danielfdsilva danielfdsilva merged commit 3e6b86f into develop Oct 30, 2023
5 checks passed
@danielfdsilva danielfdsilva deleted the aerosol-discovery-trent branch October 30, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants